[FLINK-40497][table] Allow materialized tables to default to ON CONFLICT DO ERROR - #29040
Open
gustavodemorais wants to merge 1 commit into
Open
[FLINK-40497][table] Allow materialized tables to default to ON CONFLICT DO ERROR#29040gustavodemorais wants to merge 1 commit into
gustavodemorais wants to merge 1 commit into
Conversation
Collaborator
raminqaf
reviewed
Aug 28, 2026
Comment on lines
+305
to
324
| /** Whether every table scanned by {@code rel} declares a watermark. */ | ||
| private static boolean allSourcesHaveWatermarks(RelNode rel) { | ||
| if (rel instanceof TableScan) { | ||
| final TableSourceTable table = | ||
| ((TableScan) rel).getTable().unwrap(TableSourceTable.class); | ||
| // An unresolvable scan can't be proven to lack a watermark, so it isn't treated as a | ||
| // reason to fall back - matching the same convention used for the physical-tree check. | ||
| return table == null | ||
| || !table.contextResolvedTable() | ||
| .getResolvedSchema() | ||
| .getWatermarkSpecs() | ||
| .isEmpty(); | ||
| } | ||
| for (RelNode input : rel.getInputs()) { | ||
| if (!allSourcesHaveWatermarks(input)) { | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
We can simplify this
private static boolean allSourcesHaveWatermarks(RelNode rel) {
if (rel instanceof TableScan) {
final TableSourceTable table =
((TableScan) rel).getTable().unwrap(TableSourceTable.class);
return table == null
|| !table.contextResolvedTable().getResolvedSchema().getWatermarkSpecs().isEmpty();
}
return rel.getInputs().stream().allMatch(DynamicSinkUtils::allSourcesHaveWatermarks);
}
Contributor
There was a problem hiding this comment.
Also noticed that collectSourcesWithoutWatermarks does the same check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A materialized table has no syntax for an explicit
ON CONFLICTclause, so it always falls back to the implicitDO DEDUPLICATEstrategy when its primary key differs from its query's upsert key. This adds an opt-in option to default it toDO ERRORinstead, avoiding the state-heavier deduplicating materializer, applied only when every source already declares a watermark so table creation never fails because of it.Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes - new option added to ExecutionConfigOptions (@PublicEvolving)Documentation
Was generative AI tooling used to co-author this PR?
2.1.235 (Claude Code) with Sonnet 5