Repository navigation
[hotfix] Add docs data, update CI and enable japicmp ahead of 1.1.0 - #59
Merged
Merged
Conversation
The sql_connector_download_table shortcode reads the connector version and Flink compatibility from docs/data/http.yml. The Flink docs use the v1.0 copy; this one carries over to the next release branch. Generated-by: Claude Code (Claude Opus 5.5)
…ly run Generated-by: Claude Code (Claude Opus 5.5)
flink-connector-parent 2.0.0 manages japicmp under com.github.siom79.japicmp, so the io.github.zentol.japicmp declaration had no version or execution and the check did not run. Switch the groupId and compare against 1.0.0-2.2. The parent only checks @public classes and the connector has none yet. Generated-by: Claude Code (Claude Opus 5.5)
1 task done
davidradl
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Groundwork for releasing 1.1.0 for Flink 2.2 and 2.3.
Brief change log
docs/data/http.yml, which thesql_connector_download_tableshortcode in the Flink docs reads, so v1.1 has it when it is branched. v1.0 gets it in [hotfix][docs] Add docs data for the SQL connector download table #60.fail-fast: falsethere.io.github.zentol.japicmpdeclaration had no version or execution, so it never ran. It only checks@Public, which the connector has none of yet.Verifying this change
mvn clean verifypasses against Flink 2.2.1 and 2.3.0, and japicmp now runs against 1.0.0-2.2.Impact and documentation
Not applicable.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5.5)