fix(dataZoom): avoid NaN in single-point shadow. close #21649#21668
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(dataZoom): avoid NaN in single-point shadow. close #21649#21668rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes slider dataZoom data shadow rendering for single-point time-axis series by avoiding NaN shadow coordinates.
Fixed issues
showDataShadowrenders nothing when the shadow-source series has a single data point on a time axis.Details
Before: What was the problem?
For slider dataZoom with
showDataShadow: trueon a time axis, a single-point shadow-source series produced a zero-width data extent.That made the time-axis shadow coordinate normalization divide by zero:
The resulting
Infinitycould then produceNaNshadow coordinates, causing the slider data shadow to disappear.After: How does it behave after the fixing?
The time-axis proportional coordinate path is now used only when the data extent span is positive and finite.
For single-point time-axis data, the slider data shadow falls back to the existing step-based coordinate path, keeping polygon/polyline points finite and allowing the shadow to render.
A regression test was added for a single-point time-axis slider dataZoom case.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
Added unit regression test:
test/ut/spec/component/dataZoom/SliderZoomView.test.tsValidation run:
npx jest --config test/ut/jest.config.cjs --coverage=false test/ut/spec/component/dataZoom/SliderZoomView.test.ts --runInBandnpx eslint src/component/dataZoom/SliderZoomView.ts test/ut/spec/component/dataZoom/SliderZoomView.test.tsgit --no-pager diff --checknpm run checktypeMerging options
Other information