fix(line): handle empty visualMap color stops. close #18066#21666
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(line): handle empty visualMap color stops. close #18066#21666rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix line series rendering when a piecewise visualMap piece has a null bound and produces no gradient color stops.
Fixed issues
visualMap.pieces[].lteis set tonull.Details
Before: What was the problem?
When a line series uses a piecewise visualMap with a piece like:
the visualMap metadata can contain
outerColorsbut no color stops.LineViewstill tried to readcolorStopsInRange[0].coord, causing:After: How does it behave after the fixing?
Line series no longer throws for this visualMap configuration.
When there are no in-range color stops,
LineViewnow handles the empty-stop case and returns the available outer color instead of building a gradient from an empty stops array.A regression test was added for the null-bound piecewise visualMap case.
Validation:
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/component/visualMap/nullBound.test.tsMerging options
Other information
N.A.