Skip to content

fix(line): respect disabled emphasis in hover. close #21634 #21664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul37wallst-sudo wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

fix(line): respect disabled emphasis in hover. close #21634 #21664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/chart/line/LineView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,9 +942,14 @@ class LineView extends ChartView {
) {
const data = seriesModel.getData();
const dataIndex = modelUtil.queryDataIndex(data, payload);
const emphasisDisabled = seriesModel.getModel('emphasis').get('disabled');

this._changePolyState('emphasis');

if (emphasisDisabled) {
return;
}

if (!(dataIndex instanceof Array) && dataIndex != null && dataIndex >= 0) {
const points = data.getLayout('points');
let symbol = data.getItemGraphicEl(dataIndex) as SymbolClz;
Expand Down Expand Up @@ -1001,6 +1006,7 @@ class LineView extends ChartView {
) {
const data = seriesModel.getData();
const dataIndex = modelUtil.queryDataIndex(data, payload) as number;
const emphasisDisabled = seriesModel.getModel('emphasis').get('disabled');

this._changePolyState('normal');

Expand All @@ -1011,12 +1017,12 @@ class LineView extends ChartView {
data.setItemGraphicEl(dataIndex, null);
this.group.remove(symbol);
}
else {
else if (!emphasisDisabled) {
symbol.downplay();
}
}
}
else {
else if (!emphasisDisabled) {
// FIXME
// can not downplay completely.
// Downplay whole series
Expand Down