-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](variant) schema template auto cast #60362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
70c3db2
implement schema template cast
gary-cloud a365d06
fix and test
gary-cloud 2fb3545
fix pipline
gary-cloud 3d6e7c2
add slot ref and delete join case
gary-cloud 947bc8c
add join, select, group, having tests
gary-cloud da360f6
cover more
gary-cloud c502501
all tests pass
gary-cloud cd777b7
maybe done
gary-cloud c21e118
use processBoundFunction
gary-cloud b7f1825
enhance fe ut
gary-cloud 72c0f66
reapply VariantSchemaCast rules
gary-cloud 60b0555
may be aborted
gary-cloud 0a04b03
enable_variant_schema_auto_cast_in_select is very complex
gary-cloud f2e44c2
hope last commit
gary-cloud 0892813
use processBoundFunction
gary-cloud 7de43f9
remove alias map
gary-cloud 06fedbd
simplify code and enhance tests
gary-cloud 11d0df9
revert multi cast of SlotReference
gary-cloud d137225
fix review
gary-cloud 668a981
fix FE UT
gary-cloud c75364b
use PathMatcher to replace fnmatch
gary-cloud 62927b2
delete shouldSuppressVariantElementAtCast
gary-cloud 151452d
Revert "use PathMatcher to replace fnmatch"
gary-cloud 2661c43
glob -> regex
gary-cloud 7675aff
fix regex to pass ut
gary-cloud 3f2fa07
fix format and enhance test
gary-cloud 0d23a24
fix format and BE UT
gary-cloud 566e82c
Merge branch 'master' into schema-cast
gary-cloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glob regex cache globals have external linkage (
g_glob_regex_cache_mutex,g_glob_regex_cache_lru,g_glob_regex_cache). Since they're only used in this translation unit, consider marking themstaticor moving them into an anonymous namespace to avoid unintended symbol exports and reduce the chance of name collisions.