Repository navigation
[fix] Harden PVC lifecycle and cross-namespace FDB references - #531
Merged
morningman merged 3 commits intoNov 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Compute-group PVC cleanup can race with scale transitions and delete claims needed by the desired replicas. Storage expansion may also be rejected when an existing claim carries historical or API-defaulted storage fields. Separately, an explicitly deleted PVC can remain blocked by an operator finalizer after its parent cluster has disappeared.
A namespace-scoped operator can also fail to resolve an FDB connection ConfigMap in another namespace because that object is outside its informer cache. Later changes to the referenced connection string may not trigger reconciliation.
This PR addresses these cases by:
The PVC finalizer controller does not initiate deletion of retained claims. This PR uses the existing manager namespace scope and does not introduce namespace-selector configuration or CRD changes.
Release note
Fix compute-group PVC cleanup and expansion during scaling, allow deleted Doris PVCs to complete finalization after their parent cluster is removed, and refresh cross-namespace FDB connection references for namespace-scoped operators.
Check List (For Author)
Test
go test ./... -count=1go vet ./...Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)