Repository navigation
[fix](helm) operator RBAC matches config/operator manifests - #529
Open
SLoeuillet wants to merge 1 commit into
Open
SLoeuillet wants to merge 1 commit into
SLoeuillet wants to merge 1 commit into
Conversation
The chart's ClusterRole and leader-election Role lagged behind
config/operator/{operator,disaggregated-operator}.yaml:
- pods delete and pods/exec create, added for the graceful compute-group
shutdown (apache#502);
- persistentvolumeclaims create, added with operator-provisioned PVCs
(ca0bf94, used when a volume sets `provisioner: operator`);
- events update in the leader-election Role.
Fixes apache#527
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #527
The Helm chart's RBAC lags behind
config/operator/operator.yamlandconfig/operator/disaggregated-operator.yaml. This adds the four rules it misses:podsdeletepods/execcreateeventsupdate (leader-election Role)persistentvolumeclaimscreateprovisioner: operator)The fourth one isn't in #527; it surfaced while diffing every rule.
Release note
doris-operator chart: RBAC now matches
config/operator/, so operator 26.x can delete and exec into pods, and create PVCs it provisions.Check List (For Author)
config/operator/operator.yamlandconfig/operator/disaggregated-operator.yamlis in the rendered chart; before this change four were missing, after it none are. The chart gains exactly those four, loses none, and renders no other object differently. Both roles passkubeconform -strict.🤖 Generated with Claude Code