Repository navigation
[feat](helm) scheduling fields for all doris-disaggregated components - #528
Open
SLoeuillet wants to merge 1 commit into
Open
SLoeuillet wants to merge 1 commit into
SLoeuillet wants to merge 1 commit into
Conversation
The chart passed only nodeSelector, and only for the MetaService. The CRD accepts nodeSelector, tolerations and affinity on metaService, feSpec and each compute group; render all three for all three, with empty defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
doris-disaggregatedrenders onlymsSpec.nodeSelector. The FE and the compute groups get no scheduling fields at all, so the chart can't place a cluster on tainted or dedicated nodes, though the CRD acceptsnodeSelector,tolerationsandaffinityon all three sections.This renders all three fields for
msSpec,feSpecandcomputeSpec(every compute group), with empty defaults invalues.yaml. It uses the shape thedorischart already uses for tolerations and affinity.Related PR: #455 (
nodeSelectoronly, FE and compute only). This one is a superset.Release note
doris-disaggregated chart:
nodeSelector,tolerationsandaffinityfor the MetaService, FE and compute groups.Check List (For Author)
helm templateoutput is byte-identical to master;metaService,feSpecand everycomputeGroups[], and the CR validates (kubeconform-strict) againstconfig/crd/bases/disaggregated.cluster.doris.com_dorisdisaggregatedclusters.yaml; a wrong-shapedtolerationsis rejected.🤖 Generated with Claude Code