perf: reuse mask in truncate_list_nulls and avoid counting all true bits#22158
Open
rluvaton wants to merge 2 commits into
Open
perf: reuse mask in truncate_list_nulls and avoid counting all true bits#22158rluvaton wants to merge 2 commits into
truncate_list_nulls and avoid counting all true bits#22158rluvaton wants to merge 2 commits into
Conversation
Contributor
|
run benchmark tpch tpcds |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing avoid-calc-number-of-set-bits (cc04caf) to 0c4ace8 (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing avoid-calc-number-of-set-bits (cc04caf) to 0c4ace8 (merge-base) diff using: tpcds File an issue against this benchmark runner |
comphead
reviewed
May 13, 2026
| let null_and_non_empty = &!nulls.inner() & not_empty.values(); | ||
| let empty = arrow::compute::kernels::cmp::eq(&lengths, zero)?; | ||
| let valid_or_empty = empty.values() | nulls.inner(); | ||
| let valid_or_empty = BooleanArray::from(valid_or_empty); |
Contributor
There was a problem hiding this comment.
I was thinking can we optimize even more and avoid allocating BooleanArray here?
Contributor
There was a problem hiding this comment.
BooleanArray::has_false used below I believe has no performatic BooleanBuffer equivalent: .iter().any(|v| !v) checks bit for bit (as a future improvement, the non-null branch could be moved to BooleanBuffer). But that BooleanArray::from BooleanBuffer should be cheap anyway.
Member
Author
There was a problem hiding this comment.
IMO This is really premature optimization, BooleanArray allocation is super cheap
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
gstvg
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
BooleanArraythat check if there is at least 1 set bitBooleanBufferbitwise operations and reuse maskWhat changes are included in this PR?
reused mask, and use helper to check if at least one false
Are these changes tested?
Existing tests
Are there any user-facing changes?
No
Cc @gstvg, @comphead