minor: Track Parquet rows and pages matched when the page index is skipped#22085
Merged
Conversation
xudong963
reviewed
May 11, 2026
xudong963
approved these changes
May 11, 2026
Co-authored-by: xudong.w <wxd963996380@gmail.com>
Contributor
|
Thank you @nuno-faria and @xudong963 |
gstvg
pushed a commit
to gstvg/arrow-datafusion
that referenced
this pull request
May 14, 2026
…ipped (apache#22085) ## Which issue does this PR close? - Follow up to apache#22031. ## Rationale for this change If page index pruning is attempted but fails, report that all rows/pages have matched, instead of returning 0 (see apache#22031 (comment)). ## What changes are included in this PR? - Track the number of matched rows and pages independently of the result of the predicate pruning. ## Are these changes tested? Existing tests. I'm not sure how to generate Parquet files that trigger this directly. ## Are there any user-facing changes? No. cc: @adriangb @2010YOUY01 --------- Co-authored-by: Daniël Heres <danielheres@gmail.com> Co-authored-by: xudong.w <wxd963996380@gmail.com> Co-authored-by: Kumar Ujjawal <ujjawalpathak6@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
If page index pruning is attempted but fails, report that all rows/pages have matched, instead of returning 0 (see #22031 (comment)).
What changes are included in this PR?
Are these changes tested?
Existing tests. I'm not sure how to generate Parquet files that trigger this directly.
Are there any user-facing changes?
No.
cc: @adriangb @2010YOUY01