-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: Add existence (semi / anti ) benchmarks for hashjoinexec #21821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coderfender
wants to merge
8
commits into
apache:main
Choose a base branch
from
coderfender:implement_additional_benchmarks_hashjoin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a9d6d68
add_existence_benchmarks_hashjoin
coderfender 6eb40b7
add_existence_benchmarks_hashjoin
coderfender 57cfc3e
Merge branch 'main' into implement_additional_benchmarks_hashjoin
coderfender ad83914
Merge branch 'main' into implement_additional_benchmarks_hashjoin
coderfender 4cfb0c5
address_review_comments
coderfender 499c5d7
Merge branch 'main' into implement_additional_benchmarks_hashjoin
coderfender 436cce4
address_review_comments
coderfender c9fab55
Merge branch 'main' into implement_additional_benchmarks_hashjoin
coderfender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also doc the fanout here, it means if we change the join type to inner join, for each probe row, how many matches can be found on average.
This can be automatically calculated from
explain analyzethe query, after changing join type toinner join, it will show up in theHashJoinExec's metrics.And later we should ensure those queries have covered different fanouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, my previous explanation may have been confusing. Let me try again.
Suppose we have the query:
Here, each probe row from
t2matches 10 rows on average fromt1, so the matching rows per probe row ratio is10:1.Although a semi join only returns whether a match exists, this ratio still matters for execution behavior, because we are evaluating short-circuit optimizations here.
So I suggest we could doc this metric here. See the original reply for how to get this matching ratio metric automatically.