-
Notifications
You must be signed in to change notification settings - Fork 2.1k
test: add test that validate partial reduce with different number of state fields #21175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rluvaton
wants to merge
7
commits into
apache:main
Choose a base branch
from
rluvaton:add-tests-for-partial-reduce-with-different-state-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+580
−43
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eb2751b
test: add test that validate partial reduce with different number of
rluvaton 122f687
typo
rluvaton 1d54115
format
rluvaton 17044a5
Remove TODO comment in aggregate function test
rluvaton fe5caaa
Merge branch 'main' into add-tests-for-partial-reduce-with-different-…
rluvaton 1930d57
test(partial-reduce): address PR review and broaden shape coverage
rluvaton cfab6f1
Merge branch 'main' into add-tests-for-partial-reduce-with-different-…
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the public signature already restricts
approx_percentile_contto 2 or 3 arguments, this extra arity check reads more like a defensive internal invariant than user-facing validation.A short comment explaining that it protects aggregate planning from accidentally feeding state-field types back into
return_typewould help clarify the intent for future readers.