fix: insert placeholder type inference showing wrong type when there is function wrapped placeholder (unknown type)#20744
Merged
berkaysynnada merged 2 commits intoApr 19, 2026
Conversation
Contributor
Author
|
@berkaysynnada can you review this when you've bandwidth? |
Contributor
|
I'll take a look ASAP |
berkaysynnada
approved these changes
Apr 17, 2026
Contributor
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
LGTM. Since this involves a pub API change, I'd prefer we wait a few days after this approval before merging, unless there's a reason to rush
berkaysynnada
deleted the
fix-placeholder-type-infernece-because-of-unknown-type
branch
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
…is function wrapped placeholder (unknown type) (apache#20744) ## Which issue does this PR close? - Closes apache#20544. ## Rationale for this change Please see apache#20544 for details. I wanted to open a PR to discuss if API change is ok for this fix ## What changes are included in this PR? This PR changes FieldRef to Option<FieldRef> for placeholders and adds test case for this. ## Are these changes tested? Yes. Existing tests and added test case for the reproduced error ## Are there any user-facing changes? Yes. this changes `prepare_param_data_types` field and its callers to use Option wrapped FieldRef instead of FieldRef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Please see #20544 for details. I wanted to open a PR to discuss if API change is ok for this fix
What changes are included in this PR?
This PR changes FieldRef to Option for placeholders and adds test case for this.
Are these changes tested?
Yes. Existing tests and added test case for the reproduced error
Are there any user-facing changes?
Yes. this changes
prepare_param_data_typesfield and its callers to use Option wrapped FieldRef instead of FieldRef.