Skip to content

Consolidate filters and projections onto TableScan #20061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriangb wants to merge 4 commits into
base: main
Choose a base branch
from
+1,458 −1,401
Open

Consolidate filters and projections onto TableScan #20061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0166985
Consolidate filters and projections onto `TableScan`
adriangb Jan 29, 2026
e611598
handle async udfs
adriangb Jan 29, 2026
fc6807c
fix tests by blocking on subquery expressions
adriangb Jan 30, 2026
eaf3a8a
update examples
adriangb Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions datafusion-examples/examples/query_planning/optimizer_rule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ pub async fn optimizer_rule() -> Result<()> {
// has been rewritten to `my_eq`
assert_eq!(
plan.display_indent().to_string(),
"Filter: my_eq(person.age, Int32(22))\
\n TableScan: person projection=[name, age]"
"TableScan: person projection=[name, age], unsupported_filters=[my_eq(person.age, Int32(22))]"
);

// The query below doesn't respect a filter `where age = 22` because
Expand Down
23 changes: 11 additions & 12 deletions datafusion-examples/examples/udf/async_udf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,18 +93,17 @@ pub async fn async_udf() -> Result<()> {

assert_batches_eq!(
[
"+---------------+------------------------------------------------------------------------------------------------------------------------------+",
"| plan_type | plan |",
"+---------------+------------------------------------------------------------------------------------------------------------------------------+",
"| logical_plan | SubqueryAlias: a |",
"| | Filter: ask_llm(CAST(animal.name AS Utf8View), Utf8View(\"Is this animal furry?\")) |",
"| | TableScan: animal projection=[id, name] |",
"| physical_plan | FilterExec: __async_fn_0@2, projection=[id@0, name@1] |",
"| | RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 |",
"| | AsyncFuncExec: async_expr=[async_expr(name=__async_fn_0, expr=ask_llm(CAST(name@1 AS Utf8View), Is this animal furry?))] |",
"| | DataSourceExec: partitions=1, partition_sizes=[1] |",
"| | |",
"+---------------+------------------------------------------------------------------------------------------------------------------------------+",
"+---------------+--------------------------------------------------------------------------------------------------------------------------------------------+",
"| plan_type | plan |",
"+---------------+--------------------------------------------------------------------------------------------------------------------------------------------+",
"| logical_plan | SubqueryAlias: a |",
"| | TableScan: animal projection=[id, name], unsupported_filters=[ask_llm(CAST(animal.name AS Utf8View), Utf8View(\"Is this animal furry?\"))] |",
"| physical_plan | FilterExec: __async_fn_0@2, projection=[id@0, name@1] |",
"| | RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 |",
"| | AsyncFuncExec: async_expr=[async_expr(name=__async_fn_0, expr=ask_llm(CAST(name@1 AS Utf8View), Is this animal furry?))] |",
"| | DataSourceExec: partitions=1, partition_sizes=[1] |",
"| | |",
"+---------------+--------------------------------------------------------------------------------------------------------------------------------------------+",
],
&results
);
Expand Down
6 changes: 2 additions & 4 deletions datafusion/core/src/datasource/view_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,7 @@ mod tests {
let expected = "\
Explain\
\n CreateView: Bare { table: \"xyz\" }\
\n Filter: abc.column2 = Int64(5)\
\n TableScan: abc projection=[column1, column2, column3]";
\n TableScan: abc projection=[column1, column2, column3], unsupported_filters=[abc.column2 = Int64(5)]";
assert_eq!(expected, actual);

let dataframe = session_ctx
Expand All @@ -411,8 +410,7 @@ mod tests {
let expected = "\
Explain\
\n CreateView: Bare { table: \"xyz\" }\
\n Filter: abc.column2 = Int64(5)\
\n TableScan: abc projection=[column1, column2]";
\n TableScan: abc projection=[column1, column2], unsupported_filters=[abc.column2 = Int64(5)]";
assert_eq!(expected, actual);

Ok(())
Expand Down
Loading
Loading