Skip to content

fix: update comment on FilterPushdownPropagation #20040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niebayes wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: update comment on FilterPushdownPropagation #20040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/filter_pushdown.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ pub struct ChildPushdownResult {
/// [`ExecutionPlan::handle_child_pushdown_result`]: crate::ExecutionPlan::handle_child_pushdown_result
#[derive(Debug, Clone)]
pub struct FilterPushdownPropagation<T> {
/// What filters were pushed into the parent node.
/// Which parent filters were pushed down into this node's children.
Copy link
Contributor

@masonh22 masonh22 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the physical optimizer filter pushdown rule, but push_down_filters() in physical-optimizer/src/filter_pushdown.rs specifically distinguishes between "parent" filters and "self" filters, which are both contained in FilterPushdownPropagation::filters.

So I think the comment should be "Which filters were pushed down..." instead of "Which parent filters were pushed down..."

pub filters: Vec<PushedDown>,
/// The updated node, if it was updated during pushdown
pub updated_node: Option<T>,
Expand Down