test: remove "Comet (Scan)" cases from microbenchmarks#4258
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
test: remove "Comet (Scan)" cases from microbenchmarks#4258andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
The "Comet (Scan)" case set COMET_ENABLED=true with COMET_EXEC_ENABLED=false, intending to isolate scan performance. With spark.comet.scan.impl=auto (the default), CometScanRule.nativeDataFusionScan refuses to install when exec is disabled, so the case actually measured native_iceberg_compat scan plus Spark ColumnarToRow. Comparing it against the other Comet case (which uses native_datafusion plus CometNativeColumnarToRow) made the result a proxy for scan-impl choice rather than the intended isolation. Drop the "Comet (Scan)" cases everywhere and rename the combined case to "Comet". Update doc comments accordingly.
mbutrovich
approved these changes
May 7, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The "scan only" benchmark runs disabled
spark.comet.exec.enabled, which actually disables scans now thatnative_datafusionis the default scan.What changes are included in this PR?
Just run Spark vs Comet, where Comet is fully enabled.
How are these changes tested?