docs: check off 53 implemented expressions in support doc#4147
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
docs: check off 53 implemented expressions in support doc#4147andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
…rt.md Audit the codebase against the expressions support doc and mark expressions that have full end-to-end implementations (JVM serde + protobuf + native execution) as supported. All verified against classOf mappings in QueryPlanSerde.scala. Expressions checked off by category: - datetime (24): date_add, date_diff, date_format, date_sub, date_trunc, dateadd, datediff, day, dayofmonth, dayofweek, dayofyear, hour, last_day, make_date, minute, month, next_day, quarter, second, trunc, unix_date, weekday, weekofyear, year - math (8): cosh, cot, expm1, hex, rand, randn, sinh, tanh - string (6): left, regexp_replace, right, split, substr, substring - hash (4): hash, sha1, sha2, xxhash64 - array (2): array_min, flatten - bitwise (2): bit_count, bit_get - collection (2): concat, size - predicate (2): isnan, rlike - map (1): str_to_map - struct (1): named_struct - conversion (1): cast
comphead
reviewed
Apr 29, 2026
Contributor
comphead
left a comment
There was a problem hiding this comment.
Thanks @andygrove let me some time to prove:
- we have sql test for each of them
- test run with
querymode
Contributor
|
Contributor
|
I'll create another PR to modify where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spark_expressions_support.mdand marked 53 expressions that have full end-to-end implementations (JVM serde + protobuf + native execution) as supportedclassOf[...] ->mappings inQueryPlanSerde.scalaExpressions checked off by category:
Test plan
classOf[...] -> Comet...mapping inQueryPlanSerde.scala🤖 Generated with Claude Code