ci: ignore dev/ changes except dev/diffs in workflows#4135
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
ci: ignore dev/ changes except dev/diffs in workflows#4135andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Several CI workflows currently use
paths-ignoreto skip runs when only documentation or changelog files are touched, but the onlydev/entry in the ignore list isdev/changelog/*.md. Other files underdev/(release scripts, copyright notices, checkstyle config, Cargo config, helper shell scripts, etc.) do not affect build or test outcomes for these workflows, yet still trigger full CI runs.The exception is
dev/diffs/, which contains the Spark patches consumed by the Iceberg and Spark SQL test workflows. Changes there must keep triggering those two workflows.What changes are included in this PR?
Replace the narrow
dev/changelog/*.mdignore entry withdev/**in:.github/workflows/iceberg_spark_test.yml(with!dev/diffs/**to keep diff edits triggering).github/workflows/spark_sql_test.yml(with!dev/diffs/**).github/workflows/pr_build_linux.yml.github/workflows/pr_build_macos.yml.github/workflows/miri.ymlThe
pr_build_*andmiriworkflows do not consumedev/diffs/, so the negation is omitted there.How are these changes tested?
Workflow-only change. The path filters take effect on the next push/PR; a follow-up commit touching only a non-diffs
dev/file (for exampledev/copyright) should not trigger these workflows, while a change underdev/diffs/should still trigger the iceberg and spark-sql workflows.