chore: fix spark ansi sum incompatibility message#4111
Open
coderfender wants to merge 3 commits intoapache:mainfrom
Open
chore: fix spark ansi sum incompatibility message#4111coderfender wants to merge 3 commits intoapache:mainfrom
coderfender wants to merge 3 commits intoapache:mainfrom
Conversation
coderfender
commented
Apr 28, 2026
| case Literal(count, _) if isNegativeNumber(count) => | ||
| withInfo(expr, "Negative repeat count is not supported") | ||
| return None | ||
| case _ => |
Contributor
Author
There was a problem hiding this comment.
This will guard against negative repeat character but still goes through for positive counts with an error message . getIncompatibleReasons() is to add the right error message on documentation
coderfender
commented
Apr 28, 2026
| Incompatible(None) | ||
| } else { | ||
| Unsupported(None) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I tried to leverage the right reason to fallback based on the pattern here
coderfender
force-pushed
the
fix_comet_sum_compatbility_level
branch
from
0d481f4 to
2fdb835
Compare
coderfender
commented
Apr 29, 2026
| object CometSum extends CometAggregateExpressionSerde[Sum] { | ||
|
|
||
| override def getIncompatibleReasons(): Seq[String] = Seq("Falls back to Spark in ANSI mode.") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
we support ansi mode so no need to fallback to spark
coderfender
commented
Apr 29, 2026
| case i: Int => i < 0 | ||
| case l: Long => l < 0 | ||
| case _ => false | ||
| } |
Contributor
Author
There was a problem hiding this comment.
added this method to be utilized later but can remove it if it is not needed
coderfender
commented
Apr 29, 2026
| val defaultPattern = TimestampFormatter.defaultPattern | ||
| if (formatStr == defaultPattern) { | ||
| Incompatible(None) | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
fallback based on specific pattern
coderfender
commented
Apr 29, 2026
|
|
||
| query expect_fallback(not fully compatible with Spark) | ||
| query expect_fallback(Datetime pattern format: yyyy-MM-dd is unsupported) | ||
| SELECT from_unixtime(t, 'yyyy-MM-dd') FROM test_from_unix_time |
Contributor
Author
There was a problem hiding this comment.
error / fallback reason is more actionable
coderfender
commented
Apr 29, 2026
Contributor
Author
coderfender
left a comment
coderfender
left a comment
There was a problem hiding this comment.
added some comments to help with review
andygrove
reviewed
Apr 29, 2026
| object CometStringRepeat extends CometExpressionSerde[StringRepeat] { | ||
|
|
||
| override def getCompatibleNotes(): Seq[String] = Seq( | ||
| override def getIncompatibleReasons(): Seq[String] = Seq( |
Member
There was a problem hiding this comment.
There is an approved PR to fix the behavior here
andygrove
reviewed
Apr 29, 2026
| override def getSupportLevel(expr: FromUnixTime): SupportLevel = { | ||
| expr.format match { | ||
| case Literal(fmt, _) => | ||
| val formatStr = fmt.toString |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4074
Rationale for this change
What changes are included in this PR?
How are these changes tested?