feat: Support Spark expression str_to_map#3654
Conversation
str_to_map
d56a2f2 to
39e444b
Compare
39e444b to
70f7686
Compare
| SELECT str_to_map(col) FROM (VALUES ('a:1,b:2'), ('x:9'), (NULL)) AS t(col) | ||
|
|
||
| -- Multi-row with custom delimiter | ||
| query spark_answer_only |
There was a problem hiding this comment.
to check Comet enabled we need to remove spark_answer_only for all possible queries
comphead
left a comment
There was a problem hiding this comment.
Thanks @unknowntpo for your contribution, I think to prove it works we need to run test queries with just query to let them run with Comet and also it would be nice to support all datatypes
|
@comphead Thanks for the review. I updated the SQL tests to use I also added table-column coverage for the string-like input types accepted by |
|
Thanks @unknowntpo please add the function to |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5587788 to
21ecbde
Compare
Okay, updated. |
comphead
left a comment
There was a problem hiding this comment.
Thanks @unknowntpo for your contribution, I think it is good to go
Thanks @comphead for reviewing my code ! |
Which issue does this PR close?
Closes #3168
Rationale for this change
Comet does not yet support Spark
StringToMap, so this change wires it through serde and native execution.What changes are included in this PR?
StringToMapto the nativeSparkStrToMapUDFSparkStrToMapin the native function registrystr_to_mapHow are these changes tested?