Skip to content

chore: Fix clippy complaints #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 1 commit into from
Mar 6, 2026
Merged

chore: Fix clippy complaints #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions native/core/benches/parquet_read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use comet::parquet::util::test_common::page_util::{

use perf::FlamegraphProfiler;
use rand::{prelude::StdRng, RngExt, SeedableRng};
use zstd::zstd_safe::WriteBuf;

fn bench(c: &mut Criterion) {
let expected_num_values: usize = NUM_PAGES * VALUES_PER_PAGE;
Expand Down Expand Up @@ -177,7 +176,7 @@ impl TestColumnReader {
fn load_page(&mut self) {
if let Some(page) = self.pages.get_next_page().unwrap() {
let num_values = page.num_values() as usize;
let buffer = Buffer::from_slice_ref(page.buffer().as_slice());
let buffer = Buffer::from_slice_ref(page.buffer());
self.inner.set_page_v1(num_values, buffer, page.encoding());
}
}
Expand Down
3 changes: 1 addition & 2 deletions native/core/src/parquet/util/test_common/page_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ use parquet::{

use super::random_numbers_range;
use bytes::Bytes;
use zstd::zstd_safe::WriteBuf;

pub trait DataPageBuilder {
fn add_rep_levels(&mut self, max_level: i16, rep_levels: &[i16]);
Expand Down Expand Up @@ -127,7 +126,7 @@ impl DataPageBuilder for DataPageBuilderImpl {
let encoded_values = encoder
.flush_buffer()
.expect("consume_buffer() should be OK");
self.buffer.extend_from_slice(encoded_values.as_slice());
self.buffer.extend_from_slice(&encoded_values);
}

fn add_indices(&mut self, indices: Bytes) {
Expand Down
Loading