feat(benchmarks): add async-profiler support to TPC benchmark scripts#3613
Merged
andygrove merged 3 commits intoapache:mainfrom Mar 3, 2026
Merged
feat(benchmarks): add async-profiler support to TPC benchmark scripts#3613andygrove merged 3 commits intoapache:mainfrom
andygrove merged 3 commits intoapache:mainfrom
Conversation
Add --async-profiler flag to run.py for profiling both Java and native (Rust/C++) code during benchmarks. Unlike JFR, async-profiler captures unified flame graphs across the JVM/native boundary, which is especially useful for Comet workloads. - Add --async-profiler, --async-profiler-dir, --async-profiler-event, and --async-profiler-format CLI flags to run.py - Install async-profiler v3.0 in the Docker image with arch detection - Set ASYNC_PROFILER_HOME in both docker-compose files - Add documentation section in README.md with usage examples - Fix minor bug: skip profiling dir creation during --dry-run
Member
Author
|
Example flamegraph generated with |
mbutrovich
approved these changes
Mar 3, 2026
Contributor
mbutrovich
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove!
Member
Author
|
Thanks @0lai0 and @mbutrovich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--async-profilerflag torun.pyfor profiling both Java and native (Rust/C++) code, with configurable event type (cpu,wall,alloc,lock) and output format (flamegraph,jfr,collapsed,text)--dry-run