Auto-generate a stateful erlangCookie#89
Conversation
|
Interesting CI error... I think I may have messed up quoting... EDIT: fixed! |
|
For the record, I haven’t had a chance to test this locally, but I am pretty sure it will resolve #88 because the “helm upgrade” cannot proceed with a different erlang cookie |
73a619a to
81a2923
Compare
81a2923 to
b8539e0
Compare
|
Alright! Finally got around to testing this! This does indeed fix the upgrading issue that is breaking CI (#78). It also works for this upgrade because it detects the previously autogenerated value and persists that! (I had an issue with base64 operations that was breaking the PR CI). FYI @willholley |
|
@willholley is this good to merge? (I don't have access to do so 😄 ) |
What this PR does / why we need it:
Discussed in #78
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Namespacecan be determined) and hard-coding the secret nameNOTES.txtthe way we have, or whether a generic message would be more helpful (i.e. is it too verbose? Should it be in a different location?)NEWS.mdseems like a helpful conventionindexto protect against missing keys like I did in allow uuid being created and managed by kubernetes #73erlangCookieshould be refactored more heavilyChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.