Skip to content

Conversation

@breautek
Copy link
Contributor

@breautek breautek commented Feb 2, 2026

Platforms affected

Motivation and Context

Solves all audit issues

Description

Updated all packages to the latest versions.
Ran npm upgrade to also update all subdependencies.
Updated eslint, copied the config from another cordova repo, adjusted slightly for what exists in this plugman repo.

p-try and p-each-series I left as is as I have plans to remove these dependencies completely.

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.60%. Comparing base (283808b) to head (ef38555).

Files with missing lines Patch % Lines
eslint.config.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   53.84%   50.60%   -3.25%     
==========================================
  Files           4        5       +1     
  Lines          78       83       +5     
==========================================
  Hits           42       42              
- Misses         36       41       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu
Copy link
Member

erisu commented Feb 3, 2026

I suggest flagging this as a breaking change and updating the Node.js engine requirements to:

"engines": {
  "node": ">=20.17.0 || >=22.9.0"
}

The current Node.js engine requirement is not compatible with cordova-lib or nopt.

It may be worth reviewing all dependencies and sub-dependencies to confirm whether >=20.17.0 || >=22.9.0 is still the minimum requirement.

@breautek breautek changed the title chore: deproll + lint upgrade chore!: deproll + lint upgrade Feb 3, 2026
@breautek breautek marked this pull request as draft February 3, 2026 14:28
@breautek
Copy link
Contributor Author

breautek commented Feb 3, 2026

The current Node.js engine requirement is not compatible with cordova-lib or nopt.

Yah I didn't think to actually check the engines and ensure they still match up. Will try to do it sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants