Skip to content

interconnect: increase UDP unack queue size and fix mem size unit #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yjhjstz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

interconnect: increase UDP unack queue size and fix mem size unit #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/interconnect/udp/ic_udpifc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ static ICGlobalControlInfo ic_control_info;

#define MAX_SEQS_IN_DISORDER_ACK (4)

#define MAX_QUEUE_SIZE (64)
#define MAX_QUEUE_SIZE (12)
/*
* UnackQueueRing
*
Expand Down Expand Up @@ -3753,7 +3753,7 @@ SetupUDPIFCInterconnect(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
int32 perQueue = Gp_interconnect_mem_size /
int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
(Gp_max_packet_size * sliceNum);

calcSndDepth = Max(Gp_interconnect_snd_queue_depth, perQueue / 2);
Expand Down
4 changes: 2 additions & 2 deletions contrib/udp2/ic_udp2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
#include "ic_types.h"
#include "udp2/ic_udp2.h"

#define MAX_QUEUE_SIZE (64)
#define MAX_QUEUE_SIZE (12)

#define HandleLastError() \
do { \
Expand Down Expand Up @@ -179,7 +179,7 @@ SetupInterconnectUDP2(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
int32 perQueue = Gp_interconnect_mem_size /
int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
(Gp_max_packet_size * sliceNum);

calcSndDepth = Max(Gp_interconnect_snd_queue_depth, perQueue / 2);
Expand Down
2 changes: 1 addition & 1 deletion src/backend/utils/misc/guc_gp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3788,7 +3788,7 @@ struct config_int ConfigureNamesInt_gp[] =
NULL
},
&Gp_interconnect_mem_size,
10, 1, 1024,
1, 1, 1024,
NULL, NULL, NULL
},

Expand Down
Loading