[CELEBORN-2236] Avoiding regular expressions for DiskFileInfo storage type determination #3562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xy2953396112
changed the title
xy2953396112
force-pushed
the
CELEBORN-2236
branch
from
b88b8e7 to
56215ea
Compare
SteNicholas
changed the title
RexXiong
reviewed
Dec 14, 2025
xy2953396112
force-pushed
the
CELEBORN-2236
branch
2 times, most recently
from
7d9f544 to
8b883fe
Compare
Contributor
Author
Contributor
xy2953396112
force-pushed
the
CELEBORN-2236
branch
4 times, most recently
from
491cee8 to
7422104
Compare
ErikFang
approved these changes
Dec 24, 2025
SteNicholas
reviewed
Dec 24, 2025
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Dec 24, 2025
common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala
Show resolved
Hide resolved
xy2953396112
force-pushed
the
CELEBORN-2236
branch
4 times, most recently
from
5bc3db7 to
b8fee72
Compare
xy2953396112
force-pushed
the
CELEBORN-2236
branch
3 times, most recently
from
16ebffd to
508cdea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3562 +/- ##
==========================================
+ Coverage 67.05% 67.15% +0.10%
==========================================
Files 357 357
Lines 21779 21860 +81
Branches 1930 1943 +13
==========================================
+ Hits 14602 14677 +75
- Misses 6160 6164 +4
- Partials 1017 1019 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xy2953396112
force-pushed
the
CELEBORN-2236
branch
from
508cdea to
1d6beba
Compare
xy2953396112
force-pushed
the
CELEBORN-2236
branch
from
1d6beba to
97e6be8
Compare
xy2953396112
force-pushed
the
CELEBORN-2236
branch
from
97e6be8 to
f4b3947
Compare
Contributor
|
Thanks, merge to main(v0.7.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoiding regular expressions for DiskFileInfo storage type determination.
Why are the changes needed?
When sending a heartbeat, the Worker iterates all FileInfo objects and uses regex matching on a large number of them to check if the file is an HDFS file, thus reducing processing efficiency.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.