fix: update CDN asset links to relative paths#454
Merged
hsluoyz merged 3 commits intoapache:masterfrom Mar 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes reliance on cdn.casbin.org for homepage language icons and the header background video by switching to locally hosted static assets, avoiding Apache.org CORS issues and redundant external hosting.
Changes:
- Replace CDN language icon URLs with local
/img/langs/*paths in the LanguageIntegration component. - Replace CDN language icon URLs with local
/img/langs/*paths in thelanguageIconMappingutility. - Replace the homepage header background video CDN URL with local
/video/background.mp4.
Reviewed changes
Copilot reviewed 3 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| static/img/langs/swift-15.svg | Add local Swift icon asset |
| static/img/langs/rust.svg | Add local Rust icon asset |
| static/img/langs/ruby.svg | Add local Ruby icon asset |
| static/img/langs/python-5.svg | Add local Python icon asset |
| static/img/langs/nodejs-1.svg | Add local Node.js icon asset |
| static/img/langs/lua-5.svg | Add local Lua icon asset |
| static/img/langs/logo-javascript.svg | Add local JavaScript icon asset |
| static/img/langs/laravel-2.svg | Add local Laravel icon asset |
| static/img/langs/kubernets.svg | Add local Kubernetes/Cloud Native icon asset |
| static/img/langs/jee-3.svg | Add local Java icon asset |
| static/img/langs/go-logo-1.svg | Add local Go icon asset |
| static/img/langs/elixir-lang-icon.svg | Add local Elixir icon asset |
| static/img/langs/dotnet-logo.svg | Add local .NET icon asset |
| static/img/langs/delphi-2.svg | Add local Delphi icon asset |
| static/img/langs/dart.svg | Add local Dart icon asset |
| static/img/langs/c.svg | Add local C/C++ icon asset |
| static/img/langs/PHP-logo.svg | Add local PHP icon asset |
| src/utils/languageIconMapping.ts | Point language name → icon mapping to local /img/langs/* paths |
| src/pages/index.js | Point homepage header video source to local /video/background.mp4 |
| src/components/LanguageIntegration/index.js | Point language carousel icons to local /img/langs/* paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hsluoyz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing CDN resources on the current page (https://cdn.casbin.org/) are currently blocked by Apache.org's CORS policy. Since Apache.org itself already leverages a CDN, hosting these resources separately may be redundant. Therefore, we should switch to relative paths and bundle these assets with the rest of our resources.
Asset path updates:
languagesarray insrc/components/LanguageIntegration/index.jsto use local/img/langs/paths instead of external CDN links.src/utils/languageIconMapping.tsto use local/img/langs/paths rather than CDN URLs.HomepageHeadercomponent (src/pages/index.js) to use the local/video/background.mp4file instead of the CDN version.