Skip to content

[CALCITE-7196] Create an optimization pass which can convert some cases of Correlate + Unnest to Unnest #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mihaibudiu merged 1 commit into from
Jan 8, 2026
Merged

[CALCITE-7196] Create an optimization pass which can convert some cases of Correlate + Unnest to Unnest #4709

mihaibudiu merged 1 commit into from
Jan 8, 2026

Conversation

@mihaibudiu
Copy link
Contributor

@mihaibudiu mihaibudiu commented Dec 27, 2025 •
edited
Loading

xiedeyantu
xiedeyantu approved these changes Dec 27, 2025
View reviewed changes
Copy link
Member

@xiedeyantu xiedeyantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about this, but the test results look good. So I'm just offering some simple suggestions for your reference. It would be great if someone else could review them.

dssysolyatin
dssysolyatin reviewed Dec 28, 2025
View reviewed changes
@xiedeyantu
Copy link
Member

xiedeyantu commented Jan 7, 2026

Is there any progress on this PR? I think it should be very helpful in improving the new decorrelation algorithm.

@mihaibudiu
Copy link
Contributor Author

mihaibudiu commented Jan 7, 2026

I will address the comments this week

xiedeyantu
xiedeyantu approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@xiedeyantu xiedeyantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If we haven't come up with any more complex cases, I think we can merge first and then add more details later.

@mihaibudiu
Copy link
Contributor Author

mihaibudiu commented Jan 8, 2026

If @dssysolyatin likes the new shape I plan to merge this soon.

@mihaibudiu mihaibudiu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jan 8, 2026
@dssysolyatin
Copy link
Contributor

dssysolyatin commented Jan 8, 2026 •
edited
Loading

LGTM, thanks @mihaibudiu!
For some reason LintTest fails

@mihaibudiu
[CALCITE-7196] Create an optimization pass which can convert some cas…
f25c7d4 
…es of Correlate + Unnest to Unnest

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mihaibudiu mihaibudiu merged commit 2a6ce48 into apache:main Jan 8, 2026
20 checks passed
@mihaibudiu mihaibudiu deleted the issue7196 branch January 8, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dssysolyatin dssysolyatin dssysolyatin approved these changes

@xiedeyantu xiedeyantu xiedeyantu approved these changes

Assignees

No one assigned

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mihaibudiu @xiedeyantu @dssysolyatin