Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the non-blocking default-partition suggestion in #958.
The in-memory persisters currently store a checkpoint under the raw
Nonekey but returnpartition_key=""in its metadata. Reloading with that returned key misses the checkpoint. SQLite already normalizes both inputs to the same default partition.Changes
Noneto""in synchronous and asynchronous in-memory save/load/list operations, including stored checkpoint metadata.Compatibility
Noneand""are now aliases, not two isolated in-memory partitions. Applications using both for the sameapp_idshare a checkpoint history. Existing last-save semantics remain unchanged, including when selecting a specific sequence ID. Callers requiring separate partitions should use distinct non-empty string keys. SQLite behavior is unchanged.How I tested this
On Python 3.11:
python -m pytest tests/core/test_persistence.py -q: 66 passed.python -m pytest tests/core -q -k "not test_visualize_dot_output": 446 passed, 4 deselected. The complete core run was attempted; those four graph-rendering cases cannot run locally because the Graphvizdotexecutable is absent.git diff --checkpassed.Notes
The complete repository test suite, other Python versions and the Sphinx documentation build were not run locally.
Checklist