Repository navigation
Conversation
Generated-by: Claude Opus 5.5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
burrfailing to start when the Python path contains a space.Closes #964
Changes
_run_serverbuilds the uvicorn command as a list instead of a string. It still usessys.executablelike fix: address RC2 vote feedback #745 did._commandnow accepts a list. The run calls were inside theisinstance(command, str)branch, so a list did nothing before. Strings are still split like before.How I tested this
tests/test_cli.py. Both tests fail on main.burr --no-openfrom my venv underApache burr/. It fails on main and starts with this change, also with--dev-mode.Notes
CI doesn't install the
cliextra (loguru), so the new tests are skipped there. I ran them locally on 3.10 and 3.13.#911 also edits the
_commandsignature line, so whichever of the two goes in second will need a small rebase.I used Claude Code while working on this; I've reviewed and tested the change myself.
Checklist