Repository navigation
fix: keep missing in-memory state loads out of application lists - #958
Merged
Merged
Conversation
Generated-by: OpenAI Codex
elijahbenizzy
approved these changes
Oct 17, 2026
elijahbenizzy
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Follow-up, not blocking: in-memory keys by raw None while SQLite normalizes to the empty string; worth aligning someday. Elijah
# Conflicts: # tests/core/test_persistence.py
Contributor
|
Merged main into your branch to resolve a conflict with #942 in the test file (both sets of tests kept, your commits untouched). Auto-merge is armed; it lands when CI is green. |
elijahbenizzy
enabled auto-merge (squash)
October 17, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling load() for an application with no saved state returns None but inserts an empty entry into the nested defaultdict used by the in-memory persisters. A later list_app_ids() then includes that unsaved application.
For example:
AsyncInMemoryPersister has the same behavior.
Changes
How I tested this
python -m pytest tests/core/test_persistence.py tests/core/test_parallelism.py tests/core/test_application.py -qcompleted with 197 passed on Windows / Python 3.11.2.git diff --checkchecks.pip checkalso passed.Notes
Prepared with OpenAI Codex assistance. The validation above was performed with Codex assistance and is not an independent human test run. No code from another project was introduced.
These in-memory persisters are intended for testing; this is not a production database change. list_app_ids() may still allocate an empty partition internally, which does not introduce phantom application IDs and is outside this fix.
The full repository test matrix, full pre-commit entry point, frontend hook and complete CI have not been run locally. Applicable Python checks were run individually.
Generated-by: OpenAI Codex
Checklist