Skip to content

Highlight telemetry rows when hovering a graph action - #953

Merged
elijahbenizzy merged 1 commit into
apache:mainfrom
HsbcJone:cursor/graph-hover-highlight-c88b
Oct 14, 2026
Merged

elijahbenizzy merged 1 commit into
apache:mainfrom
HsbcJone:cursor/graph-hover-highlight-c88b

Conversation

@HsbcJone

@HsbcJone HsbcJone commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Hovering an action in the graph view now highlights the matching rows in the telemetry UI, the reverse of the existing telemetry-to-graph hover.

Closes #275

Changes

  • Graph hover is keyed by action name plus the application and partition that own the graph, because one action can run many times.
  • Pointing at a node highlights every step, span, and insight line for that action, and the node uses the existing graph hover style.
  • Hovering a telemetry row still highlights only that sequence. The two hover sources clear each other.
  • Nested applications that reuse an action name do not highlight each other.

How I tested this

In telemetry/ui:

  • npm ci
  • npm run build (tsc and Vite)
  • npm run lint
  • npm run format
  • npx vitest run (5 passed, including 4 new cases for the hover rule)

Notes

The earlier attempt on this issue had no pull request and the issue was unassigned, so this picks it up.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Graph nodes are actions, and one action can run many times, so this hover
is the action name scoped to its application. Telemetry rows and insight
lines for that action use the same highlight as a direct row hover.

Co-authored-by: mengxiaopeng <602012854@qq.com>
@github-actions github-actions Bot added the area/ui Burr UI (telemetry frontend) label Oct 8, 2026
@elijahbenizzy
elijahbenizzy enabled auto-merge (squash) October 13, 2026 21:23
@elijahbenizzy
elijahbenizzy self-requested a review October 13, 2026 21:23
@elijahbenizzy
elijahbenizzy merged commit f8488d0 into apache:main Oct 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui Burr UI (telemetry frontend)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add highlight on graph view

3 participants