Repository navigation
Improve input validation in LocalBackend and default server binding - #795
Closed
andreahlert wants to merge 2 commits into
Closed
andreahlert wants to merge 2 commits into
andreahlert wants to merge 2 commits into
Conversation
- Adds identifier validation for project_id and app_id in LocalBackend to ensure only safe characters are accepted. - Introduces a path containment helper that resolves and validates paths stay within the configured base directory. - Changes the default tracking server bind address from 0.0.0.0 to 127.0.0.1 for local development, aligning with common practice. Signed-off-by: André Ahlert <andre@aex.partners>
andreahlert
requested review from
elijahbenizzy and
skrawcz
and removed request for
skrawcz
June 2, 2026 10:48
Signed-off-by: André Ahlert <andre@aex.partners>
|
This PR has had no activity for 96 days. Feel free to reopen when you are ready to continue. |
Contributor
|
@andreahlert thanks for this, and sorry it fell through the cracks on our side. Carried forward with your commit intact in #948, with a few more call sites covered and the helper shared with the client. That PR supersedes this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change tightens input handling in the local tracking backend and updates the default dev server configuration.
Changes:
project_idandapp_ididentifiers with a strict character allowlist_safe_join()helper that resolves and bounds-checks paths against the configured base directory127.0.0.1instead of0.0.0.0Includes regression tests for identifier and path validation.