Fix checksum calculation bug when the payload is a CompositeByteBuf with readerIndex > 0 - #4196

Merged

merlimat merged 39 commits into

apache:masterfrom

lhotari:lh-fix-compositebuffer-checksum

Feb 7, 2024

Commits on Jan 31, 2024

Add a test that reproduces a bug in checksum calculation
lhotari
committed
9fb47f5
Revert "Fixed unnecessary copy to heap (#2701)" changes to ByteBufList
lhotari
committed
0707710
Remove CompositeBuffer unwrapping in DigestManager
lhotari
committed
fe9301d
Rename update -> internalUpdate so that unwrapping logic could be added to update
lhotari
committed
532de4f
Remove unnecessary unwrapping logic in Java9IntHash
lhotari
committed
9a39d6b
Add safe way to handle CompositeByteBuf
lhotari
committed
986942d
Add license header
lhotari
committed
0669a66
Fix checkstyle
lhotari
committed
4036a3a
Refactor ByteBuf visitor solution
lhotari
committed
7a8c200
Fix checkstyle
lhotari
committed
b5b42ee
Reformat
lhotari
committed
81e9d2d
Refactor recursive visiting
lhotari
committed
6c7e6e0
Revisit equals, hashCode and toString
lhotari
committed
c19ae5d

Commits on Feb 1, 2024

Commits on Feb 2, 2024

Commits on Feb 3, 2024

Fix missing depth increment that prevents StackOverflowException
lhotari
committed
a751294
Properly handle the depth increase and decrease
lhotari
committed
5f8fef5
Remove unnecessary condition
lhotari
committed
bb703ab
Use more efficient way to read bytes to the target array
lhotari
committed
2b79716
Don't use ByteBufVisitor if it's not necessary
lhotari
committed
f650b9b
Revert "Fix bug in Java9IntHash calculation that assumed crc32c_update(x) == ~crc32c_update(~x)"
lhotari
committed
d21a5cd
Fix issue in resume byte[] version that was added
lhotari
committed
a9ed5e4

Commits on Feb 4, 2024

Polish ByteBufVisitor
lhotari
committed
b7d5795
Use extracted method
lhotari
committed
34c1c8a
Fix bug with array handling
lhotari
committed
be20948
Polish ByteBufVisitor
lhotari
committed
7998659
Optimize the buffer copying in the case where array or memory address cannot be accessed
lhotari
committed
b691316
Check if memory address is accepted
lhotari
committed
0af1556
Improve comments about complement (current = ~current) in resume
lhotari
committed
317aab7
Print thread dump when build is cancelled
lhotari
committed
2c73dca

Commits on Feb 5, 2024

Filter empty buffers and arrays in ByteBufVisitor
lhotari
committed
c215db8