GH-47222: [CI][C++] Add a CI job that uses the same build options for JNI on macOS#47305
GH-47222: [CI][C++] Add a CI job that uses the same build options for JNI on macOS#47305kou merged 1 commit intoapache:mainfrom
Conversation
|
|
.github/workflows/cpp_extra.yml
Outdated
There was a problem hiding this comment.
FYI: v5 has been released few hours ago.
https://github.com/actions/checkout/releases/tag/v5.0.0
Can we use checkout@v5?
There was a problem hiding this comment.
actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 uses the v5.0.0.
There was a problem hiding this comment.
Thanks. I thought If we use checkout@v5, CI will use a newer version (like v5.0.1) automatically.
Anyway, Just It was just the FYI. Please ignore.
There was a problem hiding this comment.
In general, we should use SHA1 instead of tag based on the Apache policy: https://infra.apache.org/github-actions-policy.html
We can consider actions/checkout as an internal action. So we can use a tag such as v5 for actions/checkout.
But both of SHA1 and tag can be updated automatically by Dependabot like #47311 . So we can always use SHA1 without a big pain.
There was a problem hiding this comment.
Thanks, I understood.
ed3a2cd to
04dcd67
Compare
8561998 to
31ce1ed
Compare
… for JNI on macOS
|
+1 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cd8e677. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Static building for JNI build on macOS is failing in apache/arrow-java. We should avoid this in apache/arrow.
See also: apache/arrow-java#799
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.