Skip to content

drop rtp packets shorter than the payload header in stream_expand - #423

Merged
aous72 merged 1 commit into
aous72:masterfrom
zayeem06:stream-expand-short-rtp-packet
Nov 14, 2026
Merged

aous72 merged 1 commit into
aous72:masterfrom
zayeem06:stream-expand-short-rtp-packet

Conversation

@zayeem06

Copy link
Copy Markdown
Contributor

packets_handler::exchange() only skipped empty datagrams, so a 1-19 byte UDP packet reached frames_handler::push(), where get_data_size() (num_bytes - 20) wrapped to ~4 GiB and mem_outfile::write() read that far past the 2048-byte packet buffer (ASan heap-buffer-overflow from a single 19-byte datagram); short packets are now ignored the same way empty ones were, and a normal main+body frame still reassembles byte-for-byte.

@aous72

aous72 commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Thank you for this PR.
I agree that packet this short can be dropped.

@aous72
aous72 merged commit 6b43df8 into aous72:master Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants