Repository navigation
Conversation
With GCC LTO, the static initializers of the sources built with per-file -msse/-mavx/-mavx2/-mavx512f flags are merged into the library's single load-time constructor. That constructor can then contain AVX-512 instructions, so loading the library crashes with SIGILL on CPUs without them. OpenEXR 3.5.3 hit this with its bundled copy of OpenJPH. Keep these files out of LTO so their initializers stay in their own functions. The AVX-512 kernels are unchanged and still selected at run time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
|
@bim-ba |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416.
Compiles the 17 sources that get per-file
-msse,-mavx,-mavx2or-mavx512fflags with-fno-lto, with a comment that says why. Without it, GCC LTO merges their static initializers into the library's single load-time constructor, which can then run AVX-512 instructions on any CPU. OpenEXR 3.5.3 crashed this way with the bundled OpenJPH.Tested with GCC 16.2.1 and
-flto=auto:ctest: 135 of 135 pass on master with the change.Not tested: clang, non-x86 targets, a full HTJ2K round trip with the patched OpenEXR build.
🤖 Generated with Claude Code