Repository navigation
docs(share-play): the stop key stops in every mode - #122
Merged
Merged
Conversation
…ame as the engine writes them
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine's F8 always asks the bridge to stop (override action 2), while the spec's stop-key row said "as the chord". The spec now says what the engine does (the chord steps back to watch first, the key stops at once), which is what a key named stop should do.
Also aligned with the engine side of anyplaynet/AnyPS5#29:
present_usis the monotonic time the picture was submitted for presentation and informational (the stream timestamp is the worker's system clock since #118),frameis a count of presented pictures, and the stream timestamp row no longer says it ispresent_us.Docs only.
Need help on this PR? Tag
@codesmith-botwith what you need.