Repository navigation
Open the cloud's web pages in the launcher's language (lang=<code>) - #246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for batch.
Every page the launcher opens on the cloud (the sign-in page, the account web, the appeal page) now carries
lang=<code>with the language the launcher is set to (en,tr,de,es,fr,pt). The web (anyplaynet/web#48) picks its language from that parameter first, then a cookie, then Accept-Language.OnlineService::open_cloud_page, after the existing check that the address is under the player's cloud. Nothing else about which addresses open changes.with_languagekeeps an existinglang=and the fragment, and handles an empty query. Unit testa_cloud_page_opens_in_the_launchers_language.tools/lb:cargo fmt --all -- --check,cargo clippy -p anyps5-launcher --all-targets -- -D warnings, and the new test pass.langignores the parameter.Need help on this PR? Tag
@codesmith-botwith what you need.