Repository navigation
ci(bridge): run the end-to-end test against a net service that speaks protocol 1 - #45
Merged
Merged
Conversation
… protocol 1 network.ref still pinned f65d3a8, from before bridge protocol 1 (network#125). Since #31 the bridge proves its token with the HMAC hello, which that service rejects ("token does not match this game start"), so bridge-e2e failed on main and on every PR. Pin network main 16774aa.
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bridge-e2efails on main and on every open PR with "player did not reach SignedIn (state=1)": the net service it starts rejects the bridge's hello with "token does not match this game start".network.refstill pins f65d3a8, from before bridge protocol 1 (network#125). Since #31 the bridge proves its token with the HMAC hello, which that net service does not speak. This pins network main (16774aa), which speaks protocol 1.Tested
bridge-e2eon this PR passes (it builds the bridge and the pinned net service and runsbridge_e2e_game).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repositorybridge-e2echeck)