Repository navigation
ci(sync): run the upstream sync every day - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Runs the upstream sync every day (04:17 UTC) instead of every Monday. Only the cron line changes, plus the three places that said weekly (the workflow header, the README paragraph, one row in
docs/dev/FORK.md).Why: the launcher issue anyplaynet/launcher 233 asks for a build newer than upstream's last release. Upstream publishes no per-commit or nightly build (its
Releaseworkflow runs only on av*tag push, and its Actions artifacts need a token), so the fork'snightlypre-release is the only fresh source. It tracks upstream as fast as the sync pull request is merged.What daily does: the job still keeps one open sync pull request. When upstream has moved and nobody has pushed to the branch, it rebuilds the branch and force-pushes it, then dispatches the builds again;
build.ymlcancels the older dispatched run for the same pull request, so builds do not pile up. A branch with a person's commits is never rewritten. A day without new upstream commits does nothing. The cost is more CI runs (free hosted runners) and a PR that changes under a reviewer; if that is a problem, merge the open PR as soon as it is green and the next day starts a fresh one.Tested
Not run: a schedule change cannot be dispatched. The job itself ran green on dispatch in #36.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repositoryNeed help on this PR? Tag
@codesmith-botwith what you need.