Repository navigation
build: use Go 1.27.3 to fix GO-2026-6809 - #58
Merged
Merged
Conversation
govulncheck reports GO-2026-6809 (crypto/x509 Certificate.Verify, fixed in Go 1.27.3) as reachable from internal/server through tls.Conn.HandshakeContext when built with Go 1.27.2, which fails both govulncheck jobs in release-candidate. Raise the toolchain directive to go1.27.3. The go directive stays at 1.27.1: that floor comes from tailscale.com, and a standard library fix is delivered through the toolchain directive. Staticcheck 2026.2.2 (v0.8.2) reads Go 1.27.3 export data, so the Go 1.27.1 exception for that job is removed: pin v0.8.2, use go-version-file: go.mod, and drop the GOTOOLCHAIN overrides in scripts/check.sh. Update AGENTS.md, CONTRIBUTING.md, docs/platforms.md and the changelog to match.
…9 fix Go 1.27.1 and 1.27.2 still compile the module but keep the vulnerable crypto/x509 code when automatic toolchain selection is turned off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
govulncheckreports GO-2026-6809 (CVE-2026-111943,crypto/x509Certificate.Verify, fixed in Go 1.27.3) as reachable with Go 1.27.2:internal/server/server.go:252limitedTLSConn.ConnectionStatecallstls.Conn.HandshakeContext, which eventually callsx509.Certificate.Verify. Both govulncheck jobs in release-candidate fail on it, which blocks every PR.What
go.mod:toolchain go1.27.2->toolchain go1.27.3. Thego 1.27.1floor is unchanged: it comes fromtailscale.com, and a standard library fix is delivered through thetoolchaindirective.STATICCHECK_VERSION: v0.8.2, the job usesgo-version-file: go.mod, and theGOTOOLCHAINoverrides in the workflow andscripts/check.share gone.Verification
Run locally with go1.27.3 selected from
go.mod:govulncheck ./...(v1.6.0 as pinned in CI, and v1.8.0): No vulnerabilities found. The same scan with Go 1.27.2 reports GO-2026-6809.scripts/check.shwith staticcheck v0.8.2: all steps passed (build, vet on three OSes, gofmt, tidy, staticcheck on three OSes, manifest and notices checks,go test -count=1 ./...).