Repository navigation
fix: recheck zcode route ownership after replacement discovery on exit handoff #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anuzzolilli-oss
merged 2 commits into
master
from
2026-11-14_zcode-exit-handoff-recheck-ownership
Nov 14, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ai: openai/gpt-6-astra)
WARNING: Cover both outcomes of the post-reroute ownership guard
Both new cases return at the earlier post-discovery check, and the existing handoff tests either successfully route or bypass this replacement block. Removing this guard would therefore leave the handoff tests passing even though a refused re-route could then strip another owner's route; an unconditional return here would also pass while leaving our exiting origin in place.
AGENTS.mdand the Gate Test Discipline require positive and negative assertions for every new gate.Add replacement-present cases that force
routeZcodeConfigto returnundefined: changed ownership must producenot-ourswith unchanged store bytes, while retained ownership must producereverted-directand remove the wrappers. A pre-wrapped signing-blocked personal store withBILI_ZCODE_ROUTE=planscan force refusal; the existing injectedlogcallback can change the stored origin when that refusal is logged, without adding a production test seam.