Skip to content

feat: add align option to radar chart#301

Merged
hustcc merged 3 commits into
mainfrom
update/radar-chart
May 6, 2026
Merged

feat: add align option to radar chart#301
hustcc merged 3 commits into
mainfrom
update/radar-chart

Conversation

@q32757468
Copy link
Copy Markdown
Contributor

@q32757468 q32757468 commented May 6, 2026

Add new `align` boolean option to radar chart that controls whether
all dimensions share the same scale. When true, dimensions are aligned
to the maximum value for absolute value comparison; when false, each
dimension scales independently.
@q32757468 q32757468 requested a review from hustcc May 6, 2026 06:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (9fd0bb4) to head (b4274b3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   81.94%   82.00%   +0.06%     
==========================================
  Files          43       43              
  Lines        2044     2051       +7     
  Branches       34       34              
==========================================
+ Hits         1675     1682       +7     
  Misses        367      367              
  Partials        2        2              
Files with missing lines Coverage Δ
src/charts/radar.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'align' property to the radar chart configuration in both the JSON schema and the Zod schema, allowing for either shared or independent scaling across dimensions. Feedback was provided to simplify the property's description to improve readability and maintain consistency between the schema definitions.

Comment thread src/charts/radar.ts
Comment thread __tests__/charts/radar.json Outdated
Shorten the description for the align option while keeping the same
meaning.
@hustcc
Copy link
Copy Markdown
Member

hustcc commented May 6, 2026

@q32757468 升级一个版本号。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@hustcc hustcc merged commit 3317809 into main May 6, 2026
1 check passed
@hustcc hustcc deleted the update/radar-chart branch May 6, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

雷达图生基本都是填满的状态

3 participants