Feat visualize#966
Conversation
- Split the visualization function from the `analysis()` method into a separate `visualize()` method - Added VisualizeResponse type and chart definition metadata - Update test cases and documentation to reflect the new architecture
- Use EventEmitter instead of callback functions to handle progress events - Simplify the parameters of the analysis and visualize methods - Update test cases and documentation to accommodate the new event system
|
🎊 PR Preview dae3a9d has been successfully built and deployed to https://antvis-AVA-preview-pr-966.surge.sh 🕐 Build time: 0.009s 🤖 By surge-preview |
There was a problem hiding this comment.
Code Review
This pull request refactors the AVA class to extend a new EventEmitter for emitting step events and splits the visualization logic out of the analysis method into a separate visualize method. It also dynamically builds the chart advisor prompt using structured chart definitions and updates the documentation and site components accordingly. The review feedback highlights several critical improvements: restoring try-catch blocks in analysis and visualize to properly emit error step events, checking for data presence before making expensive LLM calls, cleaning up empty event sets in EventEmitter to prevent memory leaks, stripping markdown code blocks from LLM outputs for robust parsing, and fixing a redundant nested ternary check in the tests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@copilot buildAdvisorPrompt 方法放到 advisor 中,这个是提示词,是 advisor 的核心代码,然后在梳理下这部分代码是否有可优化的地方。 |
|
@copilot readme 中,在 📖 Quick Start 章节后面,加上 Document,介绍 AVA 的几个 API 以及使用方式,描述简洁精炼一些,可以配合小篇幅的示意代码。 |
已调整: |
已在 README 的 |
|
|
@copilot api 还缺少 new AVA 的介绍。 |
已调整,提交
|
已补充 |

Uh oh!
There was an error while loading. Please reload this page.