Repository navigation
fix: preserve Vulkan query pointer types with current V3 - #50
Merged
Merged
Conversation
Collaborator
Author
|
Additional current-V3 verification: source-built bfc309e17e7e8fd23f4c1e2444b8d8646ec13ddf with TinyCC played the public bundled portrait sample on GTX 1060, rendered the ImGui 1.93 overlay, and exited cleanly on held Escape. All 737 decoded 1920x1080 NV12 frames matched FFmpeg byte-for-byte (0 mismatches, maximum byte difference 0). This local integration used the fixed Vulkan and allocator checkouts; it does not imply the unchanged historical release pins already include those dependency fixes. The current-master CI lane also passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep concrete Vulkan struct-pointer types for count-only and array-output queries, avoiding the V3 argument-copying/null-dereference bug reported in vlang/v#31480. Generated bindings, API signatures, dependency pins and release metadata are unchanged.
Verification
Current V3 f7afd8eadc74d7937eaa8938305bab3195bdc8df builds successfully. With the Vulkan and allocator fixes now on their public default branches, the desktop example completes a 60-frame run and the video player discovers devices and plays H.264 on GTX 1060 with the Dear ImGui 1.93 overlay. Video unit tests pass with current V3 and supported stable V. The existing current-master CI lane will verify the integrated default-branch dependencies before merge.
The local integrated V3 hardware test intentionally uses the fixed dependency checkouts. Existing release pins are retained; this PR does not claim that old released dependencies already contain those fixes or publish new dependency releases.