Repository navigation
Use Dear ImGui 1.93 standard with opt-in playback UI diagnostics - #48
Merged
Merged
Conversation
Collaborator
Author
|
Maintenance review: all seven supported release/fresh-install checks passed at a039988, including Linux/Windows stable and pinned V3, shared/static Linux and fresh VPM caches. Local playback/visual checks also passed against the actual published standard tag. The optional current-master lane remains failing and is not suppressed: V 6dd8bb85fc0f9bba05b6be5aad5df4d443c26cd5 changed vmemset length from isize to int. The same standalone call reproduces the error without ImGui, and player_decode.v is unchanged from the base commit. This is separate forward-compatibility work, not a failure of the selected release graph. No upstream report is being filed by this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select the released antono2.imgui v0.4.0-standard in both v.mod and compatibility.json. The player does not use docking; other dependency/compiler pins are unchanged. Add --imgui-demo as an opt-in real-renderer/input diagnostic while leaving ordinary playback unchanged.
Local Linux verification: stable V/TinyCC build, all four V software test files, two Python compatibility tests, strict V3 frontend check, real GTX1060 Vulkan Video playback with the Dear ImGui 1.93 overlay, mouse input, resize and clean Escape shutdown. All 737 decoded first-loop frames match FFmpeg byte-for-byte. Detailed scope and limits are recorded in docs/validation-imgui-1.93.md. Windows hardware playback remains postponed; no player release is proposed. Required current-head CI must pass before merge.