Repository navigation
Pass a typed null for V3 Vulkan device count queries - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current strict V3 generates a non-null pointer to a null handle for the untyped nil output argument in vkEnumeratePhysicalDevices. Vulkan treats that as an output-buffer call with zero capacity, so the player incorrectly reports no devices. Use an explicitly typed null pointer for the count-only query instead.
The latest-master advisory job already passes all 3 parser tests after #34; device discovery was its remaining failure. The local clean upstream V3/TinyCC build now passes the existing Lavapipe loader smoke test and lists llvmpipe. Full pinned Linux/Windows and latest-master CI will validate this change. This tests loader dispatch and discovery only, not H.264 hardware decoding.