Repository navigation
fix: preserve C names for opaque Vulkan basetypes - #29
Merged
antono3 merged 1 commit intoNov 6, 2026
Merged
Conversation
antono3
deleted the
maintenance/preserve-opaque-basetype-c-names-20261106
branch
November 6, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulkan-Docs v1.4.368 adds the opaque pointer typedef
VkInternalHandleNV. The emitter stripsVkfrom the V alias and incorrectly also strips it from the C typedef name, producingC.InternalHandleNV, which the header does not define. Preserve the registry name on the C side while retaining the existing public V alias.Add a V ABI probe that compiles and checks the handle is pointer-sized against generated v1.4.368 bindings and matching headers. Extend the historical-registry CI matrix to cover this registry; committed-snapshot, historical, pinned-V3, and Windows generation checks remain applicable.
Reproduction: the ABI probe fails locally against the unmodified generated update with GCC's
unknown type name InternalHandleNV, matching Vulkan PR #86's current-V failure. CI will regenerate through the canonical emitter and compile the regression probe. Existing generated snapshots are not hand-edited. No published API/ABI, dependency pins, release tags, or upstream repositories change.